Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not configure BlueField NICs in DPU mode #816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not configure BlueField NICs in DPU mode #816

wants to merge 1 commit into from

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Dec 13, 2024 •
edited
Loading

Fixes #662

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Dec 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12360865509

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 47.223%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/vendors/mellanox/mellanox.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller_helper.go 4 62.14%
Totals Coverage Status
Change from base Build 12298677979: -0.04%
Covered Lines: 7202
Relevant Lines: 15251
💛 - Coveralls

adrianchiris
adrianchiris reviewed Dec 16, 2024
View reviewed changes
pkg/vendors/mellanox/mellanox.go Outdated
log.Log.V(2).Info("mellanox-plugin: configFW(): can't get DPU mode for NIC", "pciAddress", pciAddr)
}
if bfMode == BluefieldDpu {
return errors.Errorf("NIC %s is in DPU mode", pciAddr)
Copy link
Collaborator

@adrianchiris adrianchiris Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate that firmware configuration changes are not supported in this case as part of the error message ?
also add a comment saying why (because reboot will not re-load firmware) and that a possible solution is to use mstfwreset b4 reboot

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to document that carefully as we have the fwreset feature we implement in the operator but that is not to switch the BF card mode

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba left review comments

@adrianchiris adrianchiris adrianchiris approved these changes

@ykulazhenkov ykulazhenkov Awaiting requested review from ykulazhenkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mellanox plugin should handle Bluefield card in DPU mode correctly
4 participants
@e0ne @coveralls @SchSeba @adrianchiris